Skip to content

New snappi model changes missing in couple fixtures.#18227

Merged
yejianquan merged 18 commits intosonic-net:masterfrom
kamalsahu0001:snappi-changes-missing
May 21, 2025
Merged

New snappi model changes missing in couple fixtures.#18227
yejianquan merged 18 commits intosonic-net:masterfrom
kamalsahu0001:snappi-changes-missing

Conversation

@kamalsahu0001
Copy link
Copy Markdown
Contributor

PR is raised to incorporate the new snappi model changes to the fixtures which are missing the changes.

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • [x ] Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@sdszhang sdszhang moved this to In Progress in SONiC Snappi May 7, 2025
@sdszhang sdszhang moved this from In Progress to To be Merged in SONiC Snappi May 7, 2025
Copy link
Copy Markdown
Contributor

@sdszhang sdszhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sdszhang
Copy link
Copy Markdown
Contributor

sdszhang commented May 9, 2025

@kamalsahu0001 can you fix the static analysis failure?

fixed static analysis
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

fixed static analysis
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

fixed static analysis
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

fixed static analysis
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@sdszhang sdszhang self-requested a review May 15, 2025 11:06
updated the port_name field.
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

fixed port_name field.
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

fixed port_name field.
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Copy Markdown
Collaborator

@yejianquan yejianquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yejianquan yejianquan merged commit 9c8e3a9 into sonic-net:master May 21, 2025
9 checks passed
@github-project-automation github-project-automation bot moved this from To be Merged to Done in SONiC Snappi May 21, 2025
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request May 21, 2025
PR is raised to incorporate the new snappi model changes to the fixtures which are missing the changes.

* Updated helper.py to incorporate new snappi changes in toggle_dut_port_state fixture

* Updated ecnhelper.py to incorporate new snappi changes to run_ecn_test_cisco8000 fixture

* Updated bpfabric_helper.py to incorporate new snappi changes in start and stop traffic

* Updated helper.py to incorporate new snappi changes to run_tx_drop_counter fixture.

* Update bpfabric_helper.py

fixed static analysis

* Update ecnhelper.py

fixed static analysis

* Update helper.py

fixed static analysis

* Update helper.py

fixed static analysis

* Update ecnhelper.py

updated

* Update ecnhelper.py

formatted ecnhelpler file.

* Update bpfabric_helper.py

formatted bpfabric_helper file.

* Update ecnhelper.py

removed additional line

* Update helper.py

formatted helper file

* Update helper.py

formatted helper file

* Update helper.py

updated the port_name field.

* Update helper.py

fixed port_name field.

* Update ecnhelper.py

fixed port_name field.

co-authorized by: jianquanye@microsoft.com
@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to 202505: #18520

@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to msft-202405: Azure/sonic-mgmt.msft#309

mssonicbld pushed a commit that referenced this pull request May 23, 2025
PR is raised to incorporate the new snappi model changes to the fixtures which are missing the changes.

* Updated helper.py to incorporate new snappi changes in toggle_dut_port_state fixture

* Updated ecnhelper.py to incorporate new snappi changes to run_ecn_test_cisco8000 fixture

* Updated bpfabric_helper.py to incorporate new snappi changes in start and stop traffic

* Updated helper.py to incorporate new snappi changes to run_tx_drop_counter fixture.

* Update bpfabric_helper.py

fixed static analysis

* Update ecnhelper.py

fixed static analysis

* Update helper.py

fixed static analysis

* Update helper.py

fixed static analysis

* Update ecnhelper.py

updated

* Update ecnhelper.py

formatted ecnhelpler file.

* Update bpfabric_helper.py

formatted bpfabric_helper file.

* Update ecnhelper.py

removed additional line

* Update helper.py

formatted helper file

* Update helper.py

formatted helper file

* Update helper.py

updated the port_name field.

* Update helper.py

fixed port_name field.

* Update ecnhelper.py

fixed port_name field.

co-authorized by: jianquanye@microsoft.com
opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
PR is raised to incorporate the new snappi model changes to the fixtures which are missing the changes.

* Updated helper.py to incorporate new snappi changes in toggle_dut_port_state fixture

* Updated ecnhelper.py to incorporate new snappi changes to run_ecn_test_cisco8000 fixture

* Updated bpfabric_helper.py to incorporate new snappi changes in start and stop traffic

* Updated helper.py to incorporate new snappi changes to run_tx_drop_counter fixture.

* Update bpfabric_helper.py

fixed static analysis

* Update ecnhelper.py

fixed static analysis

* Update helper.py

fixed static analysis

* Update helper.py

fixed static analysis

* Update ecnhelper.py

updated

* Update ecnhelper.py

formatted ecnhelpler file.

* Update bpfabric_helper.py

formatted bpfabric_helper file.

* Update ecnhelper.py

removed additional line

* Update helper.py

formatted helper file

* Update helper.py

formatted helper file

* Update helper.py

updated the port_name field.

* Update helper.py

fixed port_name field.

* Update ecnhelper.py

fixed port_name field.

co-authorized by: jianquanye@microsoft.com

Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
PR is raised to incorporate the new snappi model changes to the fixtures which are missing the changes.

* Updated helper.py to incorporate new snappi changes in toggle_dut_port_state fixture

* Updated ecnhelper.py to incorporate new snappi changes to run_ecn_test_cisco8000 fixture

* Updated bpfabric_helper.py to incorporate new snappi changes in start and stop traffic

* Updated helper.py to incorporate new snappi changes to run_tx_drop_counter fixture.

* Update bpfabric_helper.py

fixed static analysis

* Update ecnhelper.py

fixed static analysis

* Update helper.py

fixed static analysis

* Update helper.py

fixed static analysis

* Update ecnhelper.py

updated

* Update ecnhelper.py

formatted ecnhelpler file.

* Update bpfabric_helper.py

formatted bpfabric_helper file.

* Update ecnhelper.py

removed additional line

* Update helper.py

formatted helper file

* Update helper.py

formatted helper file

* Update helper.py

updated the port_name field.

* Update helper.py

fixed port_name field.

* Update ecnhelper.py

fixed port_name field.

co-authorized by: jianquanye@microsoft.com

Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
PR is raised to incorporate the new snappi model changes to the fixtures which are missing the changes.

* Updated helper.py to incorporate new snappi changes in toggle_dut_port_state fixture

* Updated ecnhelper.py to incorporate new snappi changes to run_ecn_test_cisco8000 fixture

* Updated bpfabric_helper.py to incorporate new snappi changes in start and stop traffic

* Updated helper.py to incorporate new snappi changes to run_tx_drop_counter fixture.

* Update bpfabric_helper.py

fixed static analysis

* Update ecnhelper.py

fixed static analysis

* Update helper.py

fixed static analysis

* Update helper.py

fixed static analysis

* Update ecnhelper.py

updated

* Update ecnhelper.py

formatted ecnhelpler file.

* Update bpfabric_helper.py

formatted bpfabric_helper file.

* Update ecnhelper.py

removed additional line

* Update helper.py

formatted helper file

* Update helper.py

formatted helper file

* Update helper.py

updated the port_name field.

* Update helper.py

fixed port_name field.

* Update ecnhelper.py

fixed port_name field.

co-authorized by: jianquanye@microsoft.com

Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
PR is raised to incorporate the new snappi model changes to the fixtures which are missing the changes.

* Updated helper.py to incorporate new snappi changes in toggle_dut_port_state fixture

* Updated ecnhelper.py to incorporate new snappi changes to run_ecn_test_cisco8000 fixture

* Updated bpfabric_helper.py to incorporate new snappi changes in start and stop traffic

* Updated helper.py to incorporate new snappi changes to run_tx_drop_counter fixture.

* Update bpfabric_helper.py

fixed static analysis

* Update ecnhelper.py

fixed static analysis

* Update helper.py

fixed static analysis

* Update helper.py

fixed static analysis

* Update ecnhelper.py

updated

* Update ecnhelper.py

formatted ecnhelpler file.

* Update bpfabric_helper.py

formatted bpfabric_helper file.

* Update ecnhelper.py

removed additional line

* Update helper.py

formatted helper file

* Update helper.py

formatted helper file

* Update helper.py

updated the port_name field.

* Update helper.py

fixed port_name field.

* Update ecnhelper.py

fixed port_name field.

co-authorized by: jianquanye@microsoft.com

Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants